Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations are failing for certain scenarios #9347

Closed
dkamburov opened this issue Apr 16, 2021 · 1 comment · Fixed by #9417 or #9858
Closed

Migrations are failing for certain scenarios #9347

dkamburov opened this issue Apr 16, 2021 · 1 comment · Fixed by #9417 or #9858
Assignees
Labels
🐛 bug Any issue that describes a bug migrations version: 12.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@dkamburov
Copy link
Contributor

Description

Member migration fails for the following scenario:

event.grid.onSomeEvent.subscribe

image

  • igniteui-angular version: 12.0.0
  • browser:

Steps to reproduce

  1. Build migrations for the following PR
  2. Apply those migrations in samples repo
  3. Open hierarchical-grid-custom-kb-navigation-sample.component.ts file

Result

onGridKeydown failed to migrate to gridKeydown

Expected result

onGridKeydown should migrate to gridKeydown
Scenarios like event.grid.onSomeEvent.subscribe should be migrated

@damyanpetev damyanpetev self-assigned this Apr 23, 2021
@damyanpetev damyanpetev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Apr 23, 2021
@zdrawku
Copy link
Contributor

zdrawku commented Jul 8, 2021

While upgrading the angular-samples project to 12.1.0-alpha.1 version I've noticed that the migrations were applied only to the templates and not the .ts files as well.

Steps to reproduce:

Observe the changes:

  • template:
    image

  • component:
    image

@zdrawku zdrawku reopened this Jul 8, 2021
@Lipata Lipata added 🛠️ status: in-development Issues and PRs with active development on them and removed ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. labels Jul 8, 2021
@jackofdiamond5 jackofdiamond5 added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug migrations version: 12.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
5 participants