Typescript 4 support #8117
Merged
Typescript 4 support #8117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanpetev
force-pushed
the
update-10-1
branch
from
96bc6f8 to
b05950f
Compare
damyanpetev
reviewed
Sep 14, 2020
| @@ -547,7 +547,7 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy { | |||
| }; | |||
| } | |||
|
|
|||
| public focused = this.active; | |||
| // public focused = this.active; | |||
There was a problem hiding this comment.
@rkaraivanov Couldn't figure out if this is supposed to do anything. Found just one reference to it in template, but typescript was complaining this is initialized before active (which is completely true, it's initially undefined when this is assigned). It's not hidden, nor described.. should I just delete it or keep it hidden and deprecated for a bit?
Edit: Seems like it was swapped with active in #6910, before it was basically the host bind for the active class and it was hidden
There was a problem hiding this comment.
I guess deprecate it and remove it in a future version.
damyanpetev
force-pushed
the
update-10-1
branch
from
b05950f to
1d028cc
Compare
valadzhov
added
💥 status: in-test
valadzhov
added
✅ status: verified
rkaraivanov
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8116
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)