-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Navigation enhancements #6910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
When swapping views use another view ref as to avoid `Failed to execute 'removeChild' on 'Node': The node to be removed is no longer a child of this node. Perhaps it was moved in a 'blur' event handler?` exception
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
…into ddincheva/focuslessKBNav
remove activeNode dependence of performing scroll methods Closes #6747
…into ddincheva/focuslessKBNav
…I/igniteui-angular into ddincheva/focuslessKBNav
zdrawku
added
💥 status: in-test
PRs currently being tested
and removed
🛠️ status: in-development
Issues and PRs with active development on them
labels
Apr 9, 2020
…I/igniteui-angular into ddincheva/focuslessKBNav
…I/igniteui-angular into ddincheva/focuslessKBNav
zdrawku
added
the
✅ status: verified
Applies to PRs that have passed manual verification
label
Apr 9, 2020
zdrawku
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
grid: general
grid: tree-grid
keyboard-navigation
version: 9.1.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6747
Closes #6882 (KB Nav. MRL)
Closes #6835
Closes #6947
Closes #5709
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changesIssues:
1. When open a cell in edit mode and press Tab key the events onCellEdit and onCellEditEnter are called 2 times
2. MRL: Arrow Left key does not work correct. Create a grid similar to the ColumnLayoutTestComponent. Click on a cell in column ContactName and press arrowLeft. First cell is selected instead of previous.
3. Row Editing: when a custom row editing template and press tab, the next row row cell is selected. Can be reproduced in the gridRowEdit sample with clicking Custom template.
4. Row editing: when the grid is scrolled and press tab on apply button not correct cell is selected:
5. When focus the grid with the tab key the event onSelection should be fired
6. When click on a Masterdetail and press Ctrl+arrow down/up the grid is not scrolled (this behavior stays as it is (The spec should be updated)) (related issue: 7048)
7. When navigate with tab or shift+tab the grid should be scrolled to the first cell. Open dev sample gridSummary. scroll down and click on a cell. Press tab key. Press Shift + tab. the first cell is not focused.
8. MRL: Navigating with Ctr+ Arrow left doe not navigate to the correct cell.
Steps to reproduce:
see unit tests:
should navigate to the first cell from the layout by pressing Ctrl + Arrow Left and Right key
should navigate to the first cell from the layout by pressing Ctrl + Arrow Right and Left key
9. MRL: Navigating with arrow Up/Down does not navigate to the correct cell. see unit tests:
should navigate using Arrow Down through cell with smaller colStart and bigger colEnd
should navigate using Arrow Down through cell with same colStart but bigger colEnd
should navigate using Arrow Up through cell with smaller colStart and bigger colEnd
should navigate down to next row inside pinned area when pinning second block in template
should navigate down to next row inside unpinned area when pinning second block in template
should navigate up to next row inside unpinned area when pinning second block in template
10. If there is no active node navigateTo method returns error.
See unit test:
navigateTo method should work in multi-row layout grid
11. Row Editing: when there is a custom row editing template with buttons using IgxRowEditTabStop directives the navigation never goes through them. (Also reproducible in master)[7049]
12. In Edge when press Esc key on a cell in edit mode it is not possible to continue with keyboard navigation.
13. When from the last row press Shift+Tab from edited cell the header is focused.
Steps to reproduce:
14. Navigation is broken in Chrome when in zoom is applied in the display setting. See coment
15. Navigation between summaries tbody and headers is not working in some cases:
shift + tab from summary to tbody when there are/is a focusable element(s) brokes the behaviour and does not select the right cell
shift + tab from summary to tbody without focusable element(s) selects the right cell but does not move the selectable style.
When navigating from tbody to header errors are thrown due to incorrect focus application. (mrl sample)
When navigating from outside the grid to the headers section nothing happens and lacks an ability to interact with it.
16 When grid is scrolled horizontal it is not possible to resize a column.
Steps to reproduce: