-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming and restructuring directives and components based on ng naming guidelines #541
Conversation
@@ -11,7 +11,7 @@ import { | |||
@Directive({ | |||
selector: "[igxInput]" | |||
}) | |||
export class IgxInputClass implements DoCheck { | |||
export class IgxInputDirective implements DoCheck { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would again be inconsistent, as the IgxLabel
is not called IgxLabelDirective
. Please check all the directives, and if they all follow the Igx<DirName>
format, then leave it as IgxInput
. If not, then we should discuss which naming to go with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I checked. The whole thing is totally inconsistent. The IgxFilterDirvective
, IgxRippleDirective
, IgxDraggableDirective
and IgxDroppableDirective
are all located under the directives
folder and follow the Igx<DirName>Directive
naming.
The IgxLabel
, IgxInputClass
, IgxLayout
and IgxButton
directives are all in their own folders and follow mostly the Igx<DirName>
naming, except for the input.
I think we should unify all this and either move them all under directives and call the classes uniformly, or move them all into their all folders and again name them uniformly, or move them all into their own folders under the directives
folder and again name them all uniformly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to make consistent all directives and modules first
Issue description is updated based on the latest comments and recommendations |
…igniteui-angular into rename-igxInput-class
Since this is a major breaking change that affects pretty much every component and directive, this should come with all necessary documentation updates, as well as sample updates ready to be deployed at the time of tagging. Please implement all README updates, demo updates, and docfx updates. Make sure to check with the Another thing is that checks for the correct naming should be performed on a CI level. Please implement this as well! |
@ddincheva I have updated the issue with additional note, all documents (topics, readme.md files and wiki pages) should be updated with the structural and naming changes (demos, docfx). Also, could you move dragdrop, filter and ripple directives in separate folders within 'directives' folder as well. @damyanpetev we are renaming some directives and components, this would affect the ig cli project. Is it possible someone from your team to check what additional changes should be implemented from cli point of view, and use this pull request as a base. This is important as it would introduce some breaking changes. |
The only task that left is to add codelyzer to the repo. @ddincheva I am going to add this to the requirements in the issue. |
Related pull request IgniteUI/igniteui-angular-samples#45 |
…into rename-igxInput-class
There is conflicting file @damyanpetev could you please have a look |
Closes #536
Additional information related to this pull request: