Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Directives and Modules naming consistency #536

Closed
7 tasks done
kdinev opened this issue Jan 31, 2018 · 0 comments
Closed
7 tasks done

Update Directives and Modules naming consistency #536

kdinev opened this issue Jan 31, 2018 · 0 comments
Assignees
Labels
🐛 bug Any issue that describes a bug input severity: low

Comments

@kdinev
Copy link
Member

kdinev commented Jan 31, 2018

Updating initial issue description

Description

Directive and Module names should be consisent for, we follow the official angular styleguide and directives like IgxInputClass should be renamed to IgxInputDirective, same applies to the exported modules.

  • Review all names of Directives and Modules and make them consistent to the naming styleguide
  • Change the structure (if needed):
  • Move standalone Directives under src/directives/'directiveNameFolder' folder
  • Directives related to components to be left in parent folder again under directives/ folder
  • Update all related topics, reademe.md files and wiki pages based on the structural and naming changes
  • Update all related samples and docfx content
  • Add codelyzer
    Note: The exported class for the IgxInput naming is inconsistent with IgxLabelModule for example.

Result

Naming is inconsistent.

Expected result

Naming is consistent

@kdinev kdinev added 🐛 bug Any issue that describes a bug input severity: low labels Jan 31, 2018
@zdrawku zdrawku assigned ddincheva and unassigned zdrawku Feb 1, 2018
@zdrawku zdrawku changed the title Rename IgxInput class to IgxInputModule Update Directives and Modules naming consistency Feb 2, 2018
ddincheva added a commit to ddincheva/igniteui-angular that referenced this issue Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug input severity: low
Projects
None yet
Development

No branches or pull requests

3 participants