Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call markForCheck in writeValue method #3572

Merged
merged 8 commits into from
Jan 15, 2019
Merged

Call markForCheck in writeValue method #3572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
484b913
fix(igx-date-picker): Call markForCheck in writeValue method, #3362
sstoyanovIG Jan 10, 2019
a4f1530
chore(igx-date-picker): Remove unused code, #3362
sstoyanovIG Jan 10, 2019
6b16f84
Merge branch 'master' into sstoyanov/bug-fix-3362-master
SAndreeva Jan 11, 2019
8a30cd4
Merge branch 'master' into sstoyanov/bug-fix-3362-master
rkaraivanov Jan 11, 2019
5c7d36a
Merge branch 'master' into sstoyanov/bug-fix-3362-master
rkaraivanov Jan 11, 2019
2454a29
Merge branch 'master' into sstoyanov/bug-fix-3362-master
rkaraivanov Jan 11, 2019
da9d074
Merge branch 'master' into sstoyanov/bug-fix-3362-master
kdinev Jan 14, 2019
2783c74
Merge branch 'master' into sstoyanov/bug-fix-3362-master
kdinev Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import {
HostListener,
ElementRef,
TemplateRef,
Directive
Directive,
ChangeDetectorRef
} from '@angular/core';
import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms';
import {
Expand Down Expand Up @@ -444,7 +445,7 @@ export class IgxDatePickerComponent implements ControlValueAccessor, EditorProvi

@ViewChild(IgxInputDirective) protected input: IgxInputDirective;

constructor(private resolver: ComponentFactoryResolver) { }
constructor(private resolver: ComponentFactoryResolver, private cdr: ChangeDetectorRef) { }

/**
*Method that sets the selected date.
Expand All @@ -461,6 +462,7 @@ export class IgxDatePickerComponent implements ControlValueAccessor, EditorProvi
*/
public writeValue(value: Date) {
this.value = value;
this.cdr.markForCheck();
}

/**
Expand Down
5 changes: 0 additions & 5 deletions projects/igniteui-angular/src/lib/grids/filtering/grid-filtering-row.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,6 @@ export class IgxGridFilteringRowComponent implements AfterViewInit {
this._conditionsOverlaySettings.outlet = this.column.grid.outletDirective;
this._operatorsOverlaySettings.outlet = this.column.grid.outletDirective;

if (this.column.dataType === DataType.Date) {
// TODO: revise usage of cdr.detectChanges() here
this.cdr.detectChanges();
}

this.input.nativeElement.focus();
}

Expand Down