Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call markForCheck in writeValue method #3572

Merged
merged 8 commits into from
Jan 15, 2019
Merged

Call markForCheck in writeValue method #3572

merged 8 commits into from
Jan 15, 2019

Conversation

sstoyanovIG
Copy link
Contributor

Closes #3362

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@sstoyanovIG
fix(igx-date-picker): Call markForCheck in writeValue method, #3362
484b913 
# Conflicts:
#	projects/igniteui-angular/src/lib/date-picker/date-picker.component.ts
@sstoyanovIG
chore(igx-date-picker): Remove unused code, #3362
a4f1530
@sstoyanovIG sstoyanovIG requested a review from bkulov January 10, 2019 15:22
@SAndreeva SAndreeva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 11, 2019
@rkaraivanov rkaraivanov merged commit 6743b15 into master Jan 15, 2019
@rkaraivanov rkaraivanov deleted the sstoyanov/bug-fix-3362-master branch January 15, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkulov bkulov bkulov approved these changes

Assignees

@SAndreeva SAndreeva

Labels
📅 date-picker filtering grid: general version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When select a date filter the date is not previewed in the input
5 participants
@sstoyanovIG @bkulov @SAndreeva @rkaraivanov @kdinev