Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Transactions - Gird Transactions + Paging interactions - Master #3448

Merged
merged 8 commits into from
Jan 2, 2019
Merged

Fix - Transactions - Gird Transactions + Paging interactions - Master #3448

merged 8 commits into from
Jan 2, 2019

Conversation

ViktorSlavov
Copy link
Contributor

Closes #3425

Additional information (check all that apply):

  • Bug fix

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code

@ViktorSlavov ViktorSlavov added 🛠️ status: in-development Issues and PRs with active development on them grid: general grid: paging version: 7.1.x transaction igxTransactionService labels Dec 14, 2018
wnvko
wnvko previously approved these changes Dec 17, 2018
View reviewed changes
@ViktorSlavov ViktorSlavov added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 17, 2018
@zdrawku zdrawku changed the base branch from master to 7.1.x December 18, 2018 14:40
@PlamenaMiteva PlamenaMiteva added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jan 2, 2019
damyanpetev
damyanpetev approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those checks probably shouldn't be tied to delete operations at all but rather the general paging functionality, ideally after the pipe determines the new page count.
Regardless, this will do fine for now.

@bazal4o bazal4o merged commit 8ebf62a into 7.1.x Jan 2, 2019
@bazal4o bazal4o deleted the vslavov/transaction-paging-grid branch January 2, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

@wnvko wnvko wnvko left review comments

@bazal4o bazal4o Awaiting requested review from bazal4o

Assignees

@PlamenaMiteva PlamenaMiteva

Labels
grid: general grid: paging transaction igxTransactionService version: 7.1.x version: 7.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViktorSlavov @damyanpetev @wnvko @bazal4o @PlamenaMiteva @zdrawku