Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When transactions are enabled and delete a row page is changed to first page #3425

Closed
nrobakova opened this issue Dec 13, 2018 · 2 comments
Closed
Assignees
Labels
🐛 bug Any issue that describes a bug 📉 regression 🔥 severity: high grid: general grid: paging transaction igxTransactionService version: 6.2.x version: 7.0.x version: 7.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@nrobakova
Copy link
Contributor

Description

When transactions are enabled and delete a row page is changed to first page

  • igniteui-angular version: 7.1.x
  • browser: N/A

Steps to reproduce

  1. Open dev sample gridRowEdit
  2. In second grid go to page 2
  3. Click on button delete for a row

Result

Page is changed to page 1

Expected result

Page should not be changed

Attachments

Attach a sample if available, and screenshots, if applicable.

@ViktorSlavov
Copy link
Contributor

This is also reproducible in 7.0.x and 6.2.x branches

zdrawku added a commit that referenced this issue Jan 8, 2019
* refactor(displayDensity): Code cleanup in display density base class

Cleaned host bindings in child components.
The displayDensity getter cannot retrun undefined anymore.

* refactor(displayDensity): Address code review suggestions

* chore(*): Added itemSize to width calculations - forOf.

* refactor(displayDensity): Fix header group

* refactor(linear-progress): modify styles and template for indeterminate state

* refactor(circular-bar): add indeterminate state and animation

* refactor(progressbar): apply type classes to the host and refactor the tests

* fix(slider): prevent snapping of maxValue to minValue

Closes #2610

* test(slider): add some tests about the exceeding bounds

Closes #2610

* test(slider): run all and modify some tests

Closes #2610

* fix(slider.spec): fix some lint errors

Closes #2610

* fix(progress): fix progress bars to work in IE11

* chore(changelog, readme): update to reflect the new indeterminate property

* refactor(progressbar): update circular progress when not in indeterminate

* test(progressbar): fix circularbar tests

Closes #1997 #1986

* test(progress): fix failing tests after binding test to host

* fix(progressbar): prevent value update when indeterminate mode is on

Closes #1997 #1986

* refactor(avatar): allow for more robust styling of the avatar

* Update avatar.component.spec.ts

* test(transaction): deleting w/ transactions + paging in grid, #3425

* fix(transaction): check for transactions when commiting delete, #3425

* fix(transaction): hier trans getAggregatedChanges uses state copy instead, #3425

* chore(*): Changed the way to get the item size.

* Update avatar.component.spec.ts

* chore(*): Added test for bug 3087.

* fix(grid): proper check for paging w/ transactions in place, #3425

* chore(*): Improved test about width for_of.

* chore(*): Fixed identation change.

* fix(grid): can no longer select deleted rows, #3424

* refactor(grid): move deleted checks to API, remove extra loop, #3424

* refactor(treeGrid): row_deleted_parent is now private, remove imports, #3424

* test(treeGrid): add row selection + transaction tests, #3424

* refactor(treeGrid): remove isRowDeleted, get deleted; use api service, #3424

* refactor(grid): remove unnecessary assignment, #3424

* fix(IgxGridCell): focus input when enter cell in edit mode #2801

* fix(igx-grid): Scroll filtered column in view, #3451

* refactor(grid): add comment to row delete+paging, change check for page, #3425

* test(forof): adding failing test for scrollNext wraparound #3365

* chore(*): fix tests using avatar #3444

* fix(forof): fixing break clause for scrollTo #3365

* chore(*): removing left-over fit

* chore(ng-add): bump Ignite UI CLI version

* test(forof): fixing some tests for better passability #3365

* refactor(*): refactor some comments and exports

hide GroupedRecords class from typedoc API doc and refactor
igx-drop-down-theme param comment

Closes #3483 #3484

* test(grid): #3047 igxGrid isn't displayed properly in IE11 when in igxTabs

* chore(*): Fixing lint errors

* fix(grid): igxGrid isn't displayed properly in IE11 in igxTabs #3047

* Include grid's unpinnedWidth and totalWidth in cell width calculation (#3465)

* test(grid): add test for summary alignment #3462

* fix(grid): include grid widths in cell width calculation #3462

* fix(summary): convert getCellWidth from getter to method #3462

* Derive possible heights after markForCheck() is called #3467 (#3479)

* fix(grid): add pipeTrigger in the AfterViewInit event #3467

* test(grid): add general test for treegrid default rendering #8347

* fix(grid): calling pipeTrigger is not needed #3467

* test(grid): move general test to component test file #3467

* test(grid): remove f from test file #3467

*  docs(*): updating changelog for 7.1.x #3495

* chore(*): adding sections for 6.2.4 and 7.0.5 as well

* test(update): Modify firstMonth selector #3508

* Fix - Convert % column width to px when calculating default column width (#3319)

* test(grid): add test for a column width in % #1245

* fix(grid): convert % to px when calculating default width #1245

* test(grid): remove fit #1245

* fix(#3332): Exception when exporting more than 8 nested levels (#3501)

* fix(#3332): Exception when exporting more than 8 level

* fix(Exporter): #3332 Adding a test.

* fix(Exporter): #3332 Improve the fix and test

* fix(Exporter): #3332 Fix was braking the existing export

* fix(headers-api-docs): set header IG main page link depending on the lang

Closes #3516

* fix(*): build errors due to displayDensity changes #3310

* chore(*): more code optimizations #3310

* igxTimePicker - editable masked input + dropdown new mode (#3394)

* feat(time-picker): initial implementation of removing dialog #2337

* feat(time picker): spin on edit functionality #2337

* feat(time picker): editable input implementation #2337

* feat(time-picker): dropdown/dialog display rework #2337

* feat(time-picker): sync dropdwwon navigation and input display #2337

* feat(time picker): emit events when necessary #2337

* feat(time picker): code restructuring and demo rework #2337

* feat(time picker): fix broken sample #2337

* feat(time picker): fix test failures and styles #2337

* feat(time-picker): minor fixes and improvements #2337

* feat(time-picker): more fixes and improvements #2337

* feat(time-picker): cover corner cases with invalid value #2337

* refactor(theme): adjust time picker theme

* feat(time picker): hide/show overlay via hidden attribute #2337

* test(timePicker): Adding TimePicker DropDown initial Tests. #2337

* test(timePicker): Adding TimePicker DropDown Tests. #2337

* feat(time-picker): mask directive placeholder #2337

* test(timePicker): Fixing falling Vertical test. #2337

* feat(time picker): some code refactoring #2337

* feat(time picker): code refactoring and bug fixing #2337

* test(timePicker): Finalizing TimePicker DropDown Tests. #2337

* feat(time picker): tests refactoring and bug fixing #2337

* feat(time picker): code styling #2337

* feat(time picker): update README.md and CHANGELOG.md #2337

* feat(time picker): minor fixes/improvements #2337

* feat(time picker): some more little refinements #2337

* chore(*): mask demo enhancement #2337

* chore(*): address review comments #2337

* chore(*): more refinements #2337

* feat(time picker): address comments form review #2337

* feat(time picker): expose enum again in common #2337

* feat(time picker): cover some more corner cases #2337

* feat(time picker): some more minor bug fixes #2337

* feat(time picker): fix undesired input event firing in IE #2337

* fix(IgxColumnMovingDropDirective): focus last active cell on column moving #3407 (#3524)

* fix(igx-grid): Add function to localize summaries, #3533 (#3534)

* chore(*): Fix 7.1.1 duplicate section in Changelog

* chore(*): Update changelog
@ViktorSlavov
Copy link
Contributor

This is merged in all relevant branches and present in master, closing it.

@ViktorSlavov ViktorSlavov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 10, 2019
@kdinev kdinev added the 🐛 bug Any issue that describes a bug label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 📉 regression 🔥 severity: high grid: general grid: paging transaction igxTransactionService version: 6.2.x version: 7.0.x version: 7.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

No branches or pull requests

4 participants