Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): dialog gets focus when is opened - 7.1.x #3279

Merged
merged 22 commits into from
Dec 11, 2018
Merged

fix(dialog): dialog gets focus when is opened - 7.1.x #3279

merged 22 commits into from
Dec 11, 2018

Conversation

tachojelev
Copy link
Contributor

#3199

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them

@tachojelev tachojelev added the ❌ status: awaiting-test PRs awaiting manual verification label Dec 3, 2018
@tachojelev tachojelev assigned rmkrmk and unassigned DiyanDimitrov Dec 4, 2018
@rmkrmk rmkrmk added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Dec 5, 2018
rkaraivanov
rkaraivanov requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the out of the box focus stealing of the focus and moving it to the dialog root element itself.

I suggest to use the igxFocus directive when we have a dialog with the default buttons and leave the user to apply the same directive for a custom content inside the dialog.

@tachojelev tachojelev added 💥 status: in-test PRs currently being tested and removed ✅ status: verified Applies to PRs that have passed manual verification labels Dec 6, 2018
@rmkrmk rmkrmk added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 7, 2018
@kdinev kdinev merged commit 31dce81 into master Dec 11, 2018
@kdinev kdinev deleted the tzhelev/fix-3199-7.1.x branch December 11, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@zdrawku zdrawku Awaiting requested review from zdrawku

Assignees

@rmkrmk rmkrmk

Labels
dialog version: 7.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tachojelev @rkaraivanov @kdinev @rmkrmk @DiyanDimitrov