Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog window does not hold the focus when opened #3199

Closed
hanastasov opened this issue Nov 28, 2018 · 0 comments
Closed

Dialog window does not hold the focus when opened #3199

hanastasov opened this issue Nov 28, 2018 · 0 comments
Assignees
@tachojelev
Labels
📈 enhancement dialog severity: low ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@hanastasov
Copy link
Contributor

Description

Open a dialog window using the igxDialog.

  • igniteui-angular version: 6.2.0, 7.0.0

Steps to reproduce

  1. Go to https://www.infragistics.com/products/ignite-ui-angular/angular/components/dialog.html
  2. Bring any of the dialogs
  3. Try to open/close/etc the dialog using the keyboard - - nothing happenns

Result

Active element is the element that opened the dialog. So the dialog opens as a modal,. but does not have focus.

Expected result

Dialog window to have focus.
@zdrawku zdrawku assigned bkulov and unassigned zdrawku Dec 3, 2018
@zdrawku zdrawku assigned rmkrmk and unassigned bkulov Dec 3, 2018
@tachojelev tachojelev self-assigned this Dec 3, 2018
@tachojelev tachojelev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Dec 3, 2018
tachojelev pushed a commit that referenced this issue Dec 3, 2018
test(dialog): add test for focused dialog when opened #3199
1fc8149
@tachojelev tachojelev mentioned this issue Dec 3, 2018
Merged
14 tasks
tachojelev pushed a commit that referenced this issue Dec 3, 2018
test(dialog): add test for focused dialog when opened #3199
5e1b432
@tachojelev tachojelev mentioned this issue Dec 3, 2018
Merged
14 tasks
tachojelev pushed a commit that referenced this issue Dec 3, 2018
test(dialog): add test for focused dialog when opened #3199
21057b8
@tachojelev tachojelev mentioned this issue Dec 3, 2018
Merged
14 tasks
tachojelev pushed a commit that referenced this issue Dec 3, 2018
fix(dialog): focus dialog on open #3199
bac34e1
tachojelev pushed a commit that referenced this issue Dec 3, 2018
fix(dialog): focus dialog on open #3199
b01b7b2
tachojelev pushed a commit that referenced this issue Dec 3, 2018
fix(dialog): focus dialog on open #3199
c6788f2
@tachojelev tachojelev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Dec 3, 2018
tachojelev pushed a commit that referenced this issue Dec 6, 2018
fix(navbar): focus buttons instead of dialog with igxFocus #3199
af6de87
tachojelev pushed a commit that referenced this issue Dec 6, 2018
chore(dialog): make lint happy #3199
efad234
tachojelev pushed a commit that referenced this issue Dec 6, 2018
chore(dialog): make lint happy #3199
89fb845
tachojelev pushed a commit that referenced this issue Dec 6, 2018
chore(dialog): make lint happy #3199
ec14378
tachojelev pushed a commit that referenced this issue Dec 6, 2018
fix(focus): import focus module in focus spec #3199
b6130a0
tachojelev pushed a commit that referenced this issue Dec 6, 2018
fix(focus): import focus module in focus spec #3199
2aa6a51
tachojelev pushed a commit that referenced this issue Dec 6, 2018
fix(focus): import focus module in focus spec #3199
59b7dc5
rkaraivanov pushed a commit that referenced this issue Dec 7, 2018
@tachojelev @rkaraivanov
fix(dialog): dialog gets focus when is opened - 6.2.x (#3276)
44195fe 
* test(dialog): add test for focused dialog when opened #3199

* fix(dialog): focus dialog on open #3199

* fix(navbar): focus buttons instead of dialog with igxFocus #3199

* chore(dialog): make lint happy #3199

* fix(focus): import focus module in focus spec #3199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tachojelev tachojelev

Labels
📈 enhancement dialog severity: low ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bkulov @zdrawku @rmkrmk @tachojelev @hanastasov