Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igxGrid - refactor header and filter cell components #3013

Closed
wants to merge 9 commits into from

Conversation

SAndreeva
Copy link
Contributor

@SAndreeva SAndreeva commented Nov 14, 2018

Closes #2972, Closes #2926, Closes #2923, Closes #2917, Closes #2783, Closes #3027, Closes #2938.

This PR introduces the following changes that are with high regression potential:

  • a new component (header group) to accommodate the header and filtering cell components;
  • all column moving and column resizing related DOM structures are moved to the new header group component;
  • MCH are hierarchical structure, comprising of these header group components, only the deepest groups should have a header and a filter cell;
  • the old header component is cleaned up, it takes care only for sorting;
  • column resizing base logic is moved to a separate service;

@npaunov npaunov added 💥 status: in-test PRs currently being tested and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 21, 2018
@SAndreeva
Copy link
Contributor Author

Close this PR and will create a new one with all changes from 6.2.x

@SAndreeva SAndreeva closed this Nov 22, 2018
@SAndreeva SAndreeva deleted the SAndreeva/header-group-component branch December 3, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants