Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtered rows are not updated when a second condition is removed #2938

Closed
npaunov opened this issue Nov 6, 2018 · 0 comments
Closed

Filtered rows are not updated when a second condition is removed #2938

npaunov opened this issue Nov 6, 2018 · 0 comments
Assignees
@bkulov
Labels
🐛 bug Any issue that describes a bug filtering 🧨 severity: medium grid: general version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@npaunov
Copy link
Contributor

npaunov commented Nov 6, 2018

Description

Filtered rows are not updated when a second condition is removed

  • igniteui-angular version: 6.2.x
  • browser: all

Steps to reproduce

  1. Open dev demos 'Grid Column Moving'
  2. Filter a column with two conditions.
  3. Resize the column so both chips are visible.
  4. Remove the second filter by removing the second chip.

Result

Filtered rows are not updated only for the first condition.

Expected result

Filtered rows should be updated only for the first condition.

Attachments

filteringtest
@bkulov bkulov added the 🛠️ status: in-development Issues and PRs with active development on them label Nov 7, 2018
bkulov pushed a commit that referenced this issue Nov 9, 2018
fix(filtering): Fix filtered data refresh on chip removal (#2938)
d7ae937
bkulov pushed a commit that referenced this issue Nov 9, 2018
fix(filtering): Simplify filtering cell visible items (#2938)
1e76ccb
bkulov pushed a commit that referenced this issue Nov 9, 2018
fix(filtering): Trigger change detection when the filtering changes (#…
10a250c 
…2938)
bkulov pushed a commit that referenced this issue Nov 14, 2018
chore(filtering): Small refactoring (#2938)
a86d460
bkulov pushed a commit that referenced this issue Nov 14, 2018
chore(filtering): Small refactoring (#2938)
0045c11
bkulov pushed a commit that referenced this issue Nov 14, 2018
chore(filtering): Small refactoring (#2938)
3e47a1a
bkulov pushed a commit that referenced this issue Nov 19, 2018
chore(filtering): Change filtering components strategy to OnPush (#2938)
334c1a2
bkulov pushed a commit that referenced this issue Nov 19, 2018
test(filtering): Fix failing tests (#2938)
0aec11c
bkulov pushed a commit that referenced this issue Nov 19, 2018
test(filtering): Fix filtering UI tests (#2938)
e1f3c4c
@SAndreeva SAndreeva mentioned this issue Nov 20, 2018
Merged
@bkulov bkulov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 20, 2018
@SAndreeva SAndreeva mentioned this issue Nov 21, 2018
Closed
bkulov pushed a commit that referenced this issue Nov 23, 2018
fix(filtering): Fix empty bool expected result (#2938)
6f92a55
kdinev pushed a commit that referenced this issue Nov 23, 2018
@SAndreeva @kdinev
igxGrid - refactor header and filter cell components 6.2.x (#3017)
00a73cf 
* feat(filtering): header group component POC #542

# Conflicts:
#	projects/igniteui-angular/src/lib/grids/column.component.ts
#	projects/igniteui-angular/src/lib/grids/grid-header.component.ts
#	projects/igniteui-angular/src/lib/grids/grid/grid.component.html
#	projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
#	projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html

* feat(filtering): header group component POC #542

# Conflicts:
#	projects/igniteui-angular/src/lib/grids/column.component.ts
#	projects/igniteui-angular/src/lib/grids/grid-base.component.ts
#	projects/igniteui-angular/src/lib/grids/grid-header-group.component.html
#	projects/igniteui-angular/src/lib/grids/grid-header-group.component.ts
#	projects/igniteui-angular/src/lib/grids/grid/grid.component.html
#	projects/igniteui-angular/src/lib/grids/grid/grid.component.ts
#	projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.component.html

* feat(filtering): some MCH related improvements #542

* feat(filtering): fix some minor issues #542

* test(*): start fixing failing tests for MCH #542

* feat(filtering): fix build error #542

* chore(filtering): Small refactoring (#2938)

* test(*): refactor failing tests #542

* feat(filtering): CD strategy for header group component #542

* feat(filtering): rework column moving dragGhost creation #542

* feat(filtering): minor fixes and improvements #542

* chore(filtering): Change filtering components strategy to OnPush (#2938)

* test(filtering): Fix failing tests (#2938)

* test(filtering): Fix filtering UI tests (#2938)

* test(filtering): filtering UI tests refactoring #542

* test(filtering): fix timer issues in filtering UI test #542

* fix(*): sorting icon not being updated when sort/groupBy via API #542

* feat(filtering): fix introduced resizer bug #542

* chore(*): review comments changes #542

* feat(filtering): fix broken behaviors #542

* chore(*): some clean up, etc. #542

* feat(filtering): some API refinements #542

* fix(filtering): Fix async issue in test (#2995)

* fix(filtering): Fix empty bool expected result (#2938)
bkulov pushed a commit that referenced this issue Nov 26, 2018
@SAndreeva
refactor(filtering): Refactor header cell component (#3017)
7fb02a4 
Related issues: #542, #2938, #2995
@bkulov bkulov mentioned this issue Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkulov bkulov

Labels
🐛 bug Any issue that describes a bug filtering 🧨 severity: medium grid: general version: 6.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bkulov @npaunov @sstoyanovIG