Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demos): fix type errors, add missing functionality in dock manager #14587

Open
wants to merge 2 commits into
base: 18.2.x
Choose a base branch
from
Open

chore(demos): fix type errors, add missing functionality in dock manager #14587

wants to merge 2 commits into from

Conversation

damyanpetev
Copy link
Member

Related to #14550

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev requested a review from MayaKirova July 25, 2024 12:23
MayaKirova
MayaKirova previously approved these changes Sep 4, 2024
View reviewed changes
@ChronosSF ChronosSF changed the base branch from 18.1.x to 18.2.x October 28, 2024 12:04
@ChronosSF ChronosSF dismissed MayaKirova’s stale review October 28, 2024 12:04

The base branch was changed.

@github-actions GitHub Actions
Copy link

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayaKirova MayaKirova MayaKirova left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
demos status: inactive Used to stale issues and pull requests version: 18.1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damyanpetev @MayaKirova