Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev demos don't run strict template checks #14550

Open
3 tasks
damyanpetev opened this issue Jul 22, 2024 · 3 comments
Open
3 tasks

Dev demos don't run strict template checks #14550

damyanpetev opened this issue Jul 22, 2024 · 3 comments
Assignees
@damyanpetev
Labels
🐛 bug Any issue that describes a bug demos 🛠️ status: in-development Issues and PRs with active development on them

Comments

@damyanpetev
Copy link
Member

Description

The main tsconfig.json does have angularCompilerOptions.strictTemplates option enabled, but dev demos build with "aot": false and don't actually perform the checks at all. When enabled there are a number of errors, for example:
image

  • fix template errors
  • enable AOT/template checks on the demos
  • add a CI step to ensure no future errors
@damyanpetev damyanpetev added 🐛 bug Any issue that describes a bug demos 🆕 status: new labels Jul 22, 2024
@damyanpetev damyanpetev self-assigned this Jul 22, 2024
@damyanpetev damyanpetev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jul 22, 2024
This was referenced Jul 25, 2024
Merged
Open
@github-actions GitHub Actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 21, 2024
@damyanpetev damyanpetev removed the status: inactive Used to stale issues and pull requests label Sep 25, 2024
@github-actions GitHub Actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Nov 25, 2024
@radomirchev
Copy link
Contributor

@damyanpetev what is the status of this bug?

@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damyanpetev damyanpetev

Labels
🐛 bug Any issue that describes a bug demos 🛠️ status: in-development Issues and PRs with active development on them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damyanpetev @radomirchev