Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid,tree-shake): use lightweight token for toolbar #13897

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

damyanpetev
Copy link
Member

Similar to #13896 the toolbar already has the token in place so using that for content query so it can be tree-shaken, though again not directly extended by the component so keeping that as type only.

Given the app imports just IgxGridComponent, IgxColumnComponent before and after:
image

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Copy link
Member

@kdinev kdinev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include a CHANGELOG.MD update.

@kdinev kdinev added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Feb 13, 2024
@damyanpetev damyanpetev mentioned this pull request Feb 13, 2024
11 tasks
@damyanpetev damyanpetev requested a review from kdinev February 13, 2024 11:39
@kdinev kdinev merged commit 659e213 into master Feb 13, 2024
6 checks passed
@kdinev kdinev deleted the dpetev/grid-toolbar-tree-shake branch February 13, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: toolbar optimization version: 17.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants