Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package tree-shaking #13562

Closed
11 tasks done
kdinev opened this issue Oct 18, 2023 · 6 comments · Fixed by #13451
Closed
11 tasks done

Improve package tree-shaking #13562

kdinev opened this issue Oct 18, 2023 · 6 comments · Fixed by #13451
Assignees
Labels
optimization refactoring 🧰 feature-request version: 17.0.x version: 17.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Oct 18, 2023

Is your feature request related to a problem? Please describe.

Currently there's parts of the packages that are not tree-shaken optimally, like:

Describe the solution you'd like

The code for the parts mentioned above should be tree-shaken when not used.

@kdinev
Copy link
Member Author

kdinev commented Oct 19, 2023

@damyanpetev @igdmdimitrov About the text-highlight directive/service. Who should be the right person to own the refactoring?

@kdinev
Copy link
Member Author

kdinev commented Oct 30, 2023

@damyanpetev @igdmdimitrov I'm reopening the issue because of the text-highlight. I still need an answer on who the owner of this should be (an issue needs to be created). Utils can also benefit from further refactor.

@damyanpetev
Copy link
Member

@kdinev Well I have to look at the small utils things that weren't tree shaking after the updates anyway, so I might as well have a look at the highlight directive too

@kdinev
Copy link
Member Author

kdinev commented Oct 30, 2023

@damyanpetev I suggest separate issues be logged for each!

@damyanpetev damyanpetev added 🐛 bug Any issue that describes a bug and removed 🐛 bug Any issue that describes a bug labels Nov 13, 2023
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jan 28, 2024
@kdinev kdinev removed the status: inactive Used to stale issues and pull requests label Jan 30, 2024
@kdinev
Copy link
Member Author

kdinev commented Jan 30, 2024

@damyanpetev Could you update the checklist with the ideas you had about refactoring the grid paginator usage for better tree-shaking?

@radomirchev radomirchev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization refactoring 🧰 feature-request version: 17.0.x version: 17.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants