Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(grids): bump watermark version #13442

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Conversation

damyanpetev
Copy link
Member

(cherry picked from commit 38818ac)

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

(cherry picked from commit 38818ac)
@damyanpetev damyanpetev requested a review from kdinev September 7, 2023 10:27
@damyanpetev damyanpetev added dependencies Pull requests that update a dependency file version: 16.1.x labels Sep 7, 2023
kdinev
kdinev previously approved these changes Sep 7, 2023
@kdinev kdinev added ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 3, 2023
@kdinev
Copy link
Member

kdinev commented Oct 3, 2023

@simeonoff The link icon is not visible at the moment:

image

kdinev
kdinev previously approved these changes Oct 3, 2023
@simeonoff
Copy link
Collaborator

@simeonoff The link icon is not visible at the moment:

image

Interesting, I will take a look at what's going on.

@simeonoff
Copy link
Collaborator

@simeonoff The link icon is not visible at the moment:
image

Interesting, I will take a look at what's going on.

@kdinev I can't reproduce this. It works fine for me with version 3.0.1 in the context of the master branch.

image

@kdinev
Copy link
Member

kdinev commented Oct 3, 2023

@simeonoff I'll try again and I'll let you know.

@kdinev
Copy link
Member

kdinev commented Oct 3, 2023

@simeonoff I still get the same result. Could you try rm -rf node_modules && nom install and see if it's still fine on your end?

@simeonoff
Copy link
Collaborator

@simeonoff I still get the same result. Could you try rm -rf node_modules && nom install and see if it's still fine on your end?

Did that and it's still visible for me in Chrome and Firefox. Fired up Safari and I encountered the problem - are you using Safari?

@kdinev kdinev added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 3, 2023
kdinev
kdinev previously approved these changes Oct 3, 2023
@damyanpetev damyanpetev merged commit 721dc79 into master Oct 4, 2023
6 checks passed
@damyanpetev damyanpetev deleted the dpetev/watermark-tree-shake branch October 4, 2023 12:27
@kdinev kdinev mentioned this pull request Oct 20, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file version: 16.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants