Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluent theme to match the MS fluent #11265

Merged
merged 12 commits into from
Mar 24, 2022
Merged

Update fluent theme to match the MS fluent #11265

merged 12 commits into from
Mar 24, 2022

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Mar 22, 2022 •
edited
Loading

Closes #11191
Related to #11129 #11120

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein desig9stein requested a review from simeonoff March 22, 2022 09:25
@desig9stein desig9stein linked an issue Mar 23, 2022 that may be closed by this pull request
Buttons inconsistency between Angular fluent and MS fluent #11191
Closed
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Mar 23, 2022
simeonoff
simeonoff requested changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the light theme variants. however, none of the new focus styles are applied for raised and flat button in the dark fluent themes.

@simeonoff simeonoff added ❌ status: not-fixed and removed ✅ status: verified Applies to PRs that have passed manual verification labels Mar 23, 2022
@desig9stein
fix:(button) fix dark fulent colors.
153673e 
- fix button-group button border in fluent theme
@desig9stein desig9stein requested a review from simeonoff March 24, 2022 09:07
@desig9stein desig9stein added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: not-fixed labels Mar 24, 2022
@simeonoff simeonoff removed the ❌ status: awaiting-test PRs awaiting manual verification label Mar 24, 2022
@simeonoff simeonoff added the ✅ status: verified Applies to PRs that have passed manual verification label Mar 24, 2022
@simeonoff simeonoff merged commit c3e5a17 into 13.1.x Mar 24, 2022
@simeonoff simeonoff deleted the mpopov/flunet-buttons-styles-13.1.x branch March 24, 2022 13:44
This was referenced Mar 25, 2022
Closed
Closed
This was referenced Mar 29, 2022
Merged
Merged
@renovate renovate bot mentioned this pull request Apr 11, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees
No one assigned
Labels
button button-theme fluent-theme icon-button ✨ themes version: 13.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons inconsistency between Angular fluent and MS fluent
2 participants
@desig9stein @simeonoff