Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon button color in Fluent Theme #11129

Closed
IvayloG opened this issue Mar 1, 2022 · 5 comments
Closed

Icon button color in Fluent Theme #11129

IvayloG opened this issue Mar 1, 2022 · 5 comments
Assignees
@simeonoff @desig9stein
Labels
fluent-theme icon-button 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@IvayloG
Copy link
Contributor

IvayloG commented Mar 1, 2022

Is your feature request related to a problem? Please describe.

Icon button hover color resolves to hsla(var(--igx-grays-800) in Fluent Theme and when observing, there is no visible change for the color on hover.

Describe the solution you'd like

Icon button hover color resolves to (--igc-primary-500) in WC. The color is applied on hover.
@didimmova
Copy link
Contributor

@desig9stein will your issue fix this one?

@desig9stein
Copy link
Contributor

@desig9stein will your issue fix this one?

@didimmova Yes, I believe It will.

@didimmova
Copy link
Contributor

@simeonoff shall we close this issue then?

@desig9stein
Copy link
Contributor

desig9stein commented Mar 15, 2022 •
edited
Loading

@simeonoff shall we close this issue then?

Don't, I will close it after my PRs for the fluent buttons are merged, I will put a reference to all issues related to fluent buttons in the PRs

@desig9stein desig9stein self-assigned this Mar 15, 2022
@desig9stein desig9stein mentioned this issue Mar 22, 2022
Merged
14 tasks
@desig9stein desig9stein added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 22, 2022
@desig9stein desig9stein mentioned this issue Mar 22, 2022
Merged
@desig9stein desig9stein added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 22, 2022
@simeonoff
Copy link
Collaborator

Fixed in #11265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

@desig9stein desig9stein

Labels
fluent-theme icon-button 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@simeonoff @IvayloG @desig9stein @didimmova