Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rowData and rowID props, use data and key #10523

Merged
merged 20 commits into from
Nov 17, 2021
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c382ccb
refactor(grid): remove rowData and rowID properties, use data and key
hanastasov Nov 16, 2021
94cd7c3
test(grid): use data and key instead of rowID and rowData
hanastasov Nov 16, 2021
c61a9e4
chore(*): fix samples to use data/key
hanastasov Nov 16, 2021
c1a65a5
fix(grid): remove unnessecary code in crud service
hanastasov Nov 17, 2021
84d3d67
chore(*): fixes in dev demos
hanastasov Nov 17, 2021
498a3c5
chore(*): add missing method in api.service
hanastasov Nov 17, 2021
45ac198
Adding migrations for rowData and rowID (#10524)
hanastasov Nov 17, 2021
134d436
chore(*): update changelog, add migrations for columns
hanastasov Nov 17, 2021
620d16d
chore(*): remove excessive symbol
hanastasov Nov 17, 2021
02c42f7
Merge branch 'master' into hanastasov/removal-rowData-rowID-master
hanastasov Nov 17, 2021
86db37d
fix(grid): add safe guard agains _data in key getter
hanastasov Nov 17, 2021
2f09f79
Merge branch 'hanastasov/removal-rowData-rowID-master' of https://git…
hanastasov Nov 17, 2021
c23d221
chore(*): fixes in demos, deprecate rowID in row context
hanastasov Nov 17, 2021
0654e07
chore(*): no need to run migration against actual implementation class
hanastasov Nov 17, 2021
5c53472
test(grid): fix tests according to row context change
hanastasov Nov 17, 2021
c250937
chore(*): update changelog
hanastasov Nov 17, 2021
0887342
chore(*): remove duplicates
hanastasov Nov 17, 2021
51ee663
fix(grid): safe guard agains undefined
hanastasov Nov 17, 2021
a84e30f
chore(*): revert noe needed
hanastasov Nov 17, 2021
2dc0baa
chore(*): CHANGELOG update
hanastasov Nov 17, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ All notable changes for each version of this project will be documented in this
Use `IgxGridToolbarComponent`, `IgxGridToolbarHidingComponent`, `IgxGridToolbarPinningComponent` instead.
- **Breaking Change** - The `rowSelected` event is renamed to `rowSelectionChanging` to better reflect its function.
- **Breaking Change** - The `columnSelected` event is renamed to `columnSelectionChanging` to better reflect its function.
- **Breaking Change** - `rowData` and `rowID` properties are removed. Use `data` and `key` instead. Use `ng update` for automatic migration.
hanastasov marked this conversation as resolved.
Show resolved Hide resolved
- **Breaking Change** - `columnsCollection` is removed. Use `columns` instead.
- **Behavioral change** - `columns` getter may now return an empty array [] in certain occasions, when grid is not yet renderd, but code is calling `grid.columns`. If this introduces behavioral changes or bugs, use `grid,columnList`. To get a column at specific index, use `grid.columnList.get(0)`
hanastasov marked this conversation as resolved.
Show resolved Hide resolved
- `igxGrid`
- Exposed a `groupStrategy` input that functions similarly to `sortStrategy`, allowing customization of the grouping behavior of the grid. Please, refer to the [Group By ](https://www.infragistics.com/products/ignite-ui-angular/angular/components/grid/groupby) topic for more information.
- `IgxColumnActionsComponent`
Expand Down
Loading