Remove rowData and rowID props, use data and key #10523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanastasov
added
❌ status: awaiting-test
* chore(*): add migrations for rowData/rowID * chore(*): remove duplicated export Co-authored-by: dobromirts <[email protected]>
…hub.com/IgniteUI/igniteui-angular into hanastasov/removal-rowData-rowID-master
damyanpetev
requested changes
Nov 17, 2021
projects/igniteui-angular/migrations/update-13_0_0/changes/members.json
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/grid/grid-row.component.html
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.interfaces.ts
Show resolved
Hide resolved
| <igx-icon *ngIf="trends.positive(cell.row.rowData)">trending_up</igx-icon> | ||
| <igx-icon *ngIf="trends.negative(cell.row.rowData)">trending_down</igx-icon> | ||
| <igx-icon *ngIf="trends.positive(cell.row.data)">trending_up</igx-icon> | ||
| <igx-icon *ngIf="trends.negative(cell.row.data)">trending_down</igx-icon> |
There was a problem hiding this comment.
Okay, since this is in the markup and the cell template variable doesn't have type information (it's any) migrations probably won't pick this up and it looks unlikely for a custom migration right now.
In that case, we should definitely add an entry in the Upgrade Guide in the docs and include examples of templates the might need manual updating
There was a problem hiding this comment.
Will definitely add an entry about that!
damyanpetev
reviewed
Nov 17, 2021
damyanpetev
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10456
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)