Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): fix getCellByColumn with virtualization #10172 #10250

Closed
wants to merge 69 commits into from

Conversation

dobromirts
Copy link
Contributor

@dobromirts dobromirts commented Oct 7, 2021

Closes #10172

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Volen99 and others added 30 commits September 30, 2021 16:53
…rective-state-master

Revert: feat(grid): implement 'ed' event
kdinev and others added 17 commits October 11, 2021 16:37
* refactor(icon-service): cache svg icons as text

* refactor(icon): return SafeHtml from IconService

* spec(icon-service): update

* refactor(icon): remove lifecycle hook changes

* docs(icon, icon-service): update after changes

* docs(icon-service): update

* refactor(icon): update template and theme

* chore(*): update svg assets

* refactor(icon-service): simplify family initialization

* spec(icon-service): fix failing test

* refactor(advanced-filtering): show friendly name for igx-select text

* refactor(excel-filter): use condition friendly name

* refactor(icon, icon-service): simplify code

* test(grid): dont include the svg icon in the query for dropdown item

* refactor(icon, icon service): cache svg icons as SafeHtml

* refactor(icon): replace svg wrapper with a div

* refactor(demos): add a new test icon

* refactor(icon): set svg and div to display block

Co-authored-by: Hristo Anastasov <[email protected]>
Co-authored-by: Hristo <[email protected]>
docs(readme): adding app builder links
fix(esf): add empty filter if no filter is applied - master
…tion-v.13.0

Fix overlay closing animation duration
fix(grid): set correct indexes of rows with selected data in the extractDataFromSelection method
hanastasov
hanastasov previously approved these changes Oct 18, 2021
@dobromirts dobromirts changed the base branch from master to 12.2.x October 19, 2021 07:11
@dobromirts dobromirts dismissed hanastasov’s stale review October 19, 2021 07:11

The base branch was changed.

@dobromirts dobromirts closed this Oct 19, 2021
@dobromirts dobromirts deleted the dTsvetkov/fix-10172-12.2.x branch October 19, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCellByColumn returns undefined on a cell click in lazy loaded grid