Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): set correct indexes of rows with selected data in the extractDataFromSelection method #10281

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

viktorkombov
Copy link
Contributor

@viktorkombov viktorkombov commented Oct 12, 2021

Closes #10276

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@viktorkombov viktorkombov added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 12, 2021
@hanastasov hanastasov requested a review from dobromirts October 12, 2021 08:09
@viktorkombov viktorkombov removed the ❌ status: awaiting-test PRs awaiting manual verification label Oct 13, 2021
@dobromirts dobromirts added the 💥 status: in-test PRs currently being tested label Oct 14, 2021
@dobromirts dobromirts added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Oct 14, 2021
@kdinev kdinev merged commit f6f6612 into master Oct 15, 2021
@kdinev kdinev deleted the vkombov/fix-10276-master branch October 15, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid: selection version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getSelectedData does not return correct values when grid has details and pagination is enabled
3 participants