Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in dev demos #10246

Merged
merged 5 commits into from
Oct 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/app/grid-cell-api/grid-cell-api.sample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import {
IgxTreeGridComponent,
IgxHierarchicalGridComponent,
CellType,
IgxGridTransaction,
IgxTransactionService
} from 'igniteui-angular';
import { HIERARCHICAL_SAMPLE_DATA } from '../shared/sample-data';

Expand Down
11 changes: 4 additions & 7 deletions src/app/grid-row-api/grid-row-api.sample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
IgxHierarchicalGridComponent,
IPinningConfig,
RowPinningPosition,
IRowDragStartEventArgs,
GridSummaryCalculationMode,
GridSummaryPosition
} from 'igniteui-angular';
Expand Down Expand Up @@ -179,7 +178,6 @@ export class GridRowAPISampleComponent implements OnInit {
public togglePinning(grid: IgxGridComponent | IgxTreeGridComponent | IgxHierarchicalGridComponent,
byIndex: boolean, index: number, key: any) {
const row: RowType = byIndex ? grid.getRowByIndex(index) : grid.getRowByKey(key);
const index2: number = row.index;
if (row.pinned) {
row.unpin();
} else {
Expand Down Expand Up @@ -308,16 +306,15 @@ export class GridRowAPISampleComponent implements OnInit {
}
}

public onEnter(args) {
public onEnter() {
this.dragIcon = 'add';
}
public onRowDragStart(args: IRowDragStartEventArgs) {
const row = args.dragData;
public onRowDragStart() {
const count = this.grid.selectedRows.length || 1;
this.countIcon = `filter_${count > 9 ? '9_plus' : `${count}`}`;
}
public onLeave(args) {
this.onRowDragStart(args);
public onLeave() {
this.onRowDragStart();
this.dragIcon = 'arrow_right_alt';
}
}
2 changes: 1 addition & 1 deletion src/app/tree-grid-groupby/tree-grid-groupby.sample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class TreeGridGroupBySampleComponent implements OnInit {
this.density = this.displayDensities[event.index].label;
}

public cellEditDone(event: any) {
public cellEditDone() {
this.groupingExpressions = [...this.groupingExpressions]; // will trigger grouping pipe
}
}
8 changes: 2 additions & 6 deletions src/app/tree/tree.sample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,18 +188,14 @@ export class TreeSampleComponent implements AfterViewInit, OnDestroy {

public ngAfterViewInit() {
this.tree.nodes.toArray().forEach(node => {
node.selectedChange.subscribe((ev) => {
// console.log(ev);
});
node.selectedChange.subscribe(() => {});
});
}

public ngOnDestroy() {
}

public toggleSelectionMode(args) {
// this.tree.selection = this.selectionModes[args.index].selectMode;
}
public toggleSelectionMode() { }

public changeDensity(args) {
this.density = this.displayDensities[args.index].selectMode;
Expand Down