Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in dev demos #10246

Merged
merged 5 commits into from
Oct 22, 2021
Merged

Fix warnings in dev demos #10246

merged 5 commits into from
Oct 22, 2021

Conversation

katherinedragieva
Copy link
Contributor

Closes #

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@hanastasov hanastasov changed the title refactor(GridCellAPISampleComponent): Fix dependencies warnings Fix dependencies warnings in dev demos Oct 7, 2021
hanastasov
hanastasov requested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@hanastasov hanastasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix warnings only on app level - for files under src/app/ and revert the changes in the product code.

@hanastasov hanastasov changed the title Fix dependencies warnings in dev demos Fix warnings in dev demos Oct 7, 2021
@katherinedragieva katherinedragieva added the ❌ status: awaiting-test PRs awaiting manual verification label Oct 13, 2021
@kdinev kdinev added version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 22, 2021
@kdinev kdinev merged commit b89e5a0 into master Oct 22, 2021
@kdinev kdinev deleted the kdragieva/fix-check-warnings branch October 22, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov approved these changes

@kdinev kdinev kdinev approved these changes

Assignees
No one assigned
Labels
refactoring version: 13.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katherinedragieva @kdinev @hanastasov