Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log: fix some parts of messages not being discarded early #10238

Open
wants to merge 1 commit into
base: support/2.14
Choose a base branch
from
Open

Log: fix some parts of messages not being discarded early #10238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/base/logger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,10 @@ class Log
template<typename T>
Log& operator<<(const T& val)
{
m_Buffer << val;
if (!m_IsNoOp) {
m_Buffer << val;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. But I don't see how users suffer from this until v2.15. Especially, given that we've deferred actual bugs. (Which is ok as v2.14.4 is already large enough.)

Copy link
Member Author

@yhabteab yhabteab Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't see how users suffer from this until v2.15.

They suffer from unnecessary log buffering, but I'm fine with not backporting it.

Especially, given that we've deferred actual bugs. (Which is ok as v2.14.4 is already large enough.)

What do you mean by actual bugs? Isn't this also a bug? Your justification doesn't make sense. Just because you think we've already backported enough, you don't want to include any other fixes? There isn't a rule that defines the size of a bug fix release, so I don't understand why you keep bringing this argument.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by actual bugs? Isn't this also a bug?

Users don't even notice this.

Just because you think we've already backported enough, you don't want to include any other fixes?

At least if users don't even notice this.

There isn't a rule that defines the size of a bug fix release,

Not a precise hard limit, but a rule of thumb, I hope.
I mean, so far we've opened backport PRs for 62(!) merged PRs.

return *this;
}

Expand Down
Loading