Log: fix some parts of messages not being discarded early #10238
Conversation
`m_IsNoOp` was introduced to avoid building up log messages that will later be discarded, like debug messages if no debug logging is configured. However, it looks like the template operator<< implemented in the header file was forgotten when adding this feature, all other places writing into `m_Buffer` already have an if guard like added by this commit.
| if (!m_IsNoOp) { | ||
| m_Buffer << val; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is fine. But I don't see how users suffer from this until v2.15. Especially, given that we've deferred actual bugs. (Which is ok as v2.14.4 is already large enough.)
There was a problem hiding this comment.
But I don't see how users suffer from this until v2.15.
They suffer from unnecessary log buffering, but I'm fine with not backporting it.
Especially, given that we've deferred actual bugs. (Which is ok as v2.14.4 is already large enough.)
What do you mean by actual bugs? Isn't this also a bug? Your justification doesn't make sense. Just because you think we've already backported enough, you don't want to include any other fixes? There isn't a rule that defines the size of a bug fix release, so I don't understand why you keep bringing this argument.
There was a problem hiding this comment.
What do you mean by actual bugs? Isn't this also a bug?
Users don't even notice this.
Just because you think we've already backported enough, you don't want to include any other fixes?
At least if users don't even notice this.
There isn't a rule that defines the size of a bug fix release,
Not a precise hard limit, but a rule of thumb, I hope.
I mean, so far we've opened backport PRs for 62(!) merged PRs.
Backport of #10177