Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨Autoscaling: Change max time to wait for EC2 readyness to 1 minute #5739

Merged
merged 2 commits into from
Apr 25, 2024
Merged

🎨Autoscaling: Change max time to wait for EC2 readyness to 1 minute #5739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ff0ef
set max time to 1 minute
sanderegg Apr 25, 2024
3e92c91
change time to start
sanderegg Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/autoscaling/src/simcore_service_autoscaling/core/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class EC2InstancesSettings(BaseCustomSettings):
description="Defines the maximum number of instances the autoscaling app may create",
)
EC2_INSTANCES_MAX_START_TIME: datetime.timedelta = Field(
default=datetime.timedelta(minutes=3),
default=datetime.timedelta(minutes=1),
description="Usual time taken an EC2 instance with the given AMI takes to be in 'running' mode "
"(default to seconds, or see https://pydantic-docs.helpmanual.io/usage/types/#datetime-types for string formating)",
)
Expand Down
2 changes: 1 addition & 1 deletion services/clusters-keeper/src/simcore_service_clusters_keeper/utils/clusters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def _convert_ec2_state_to_cluster_state(
return ClusterState.STOPPED


_EC2_INSTANCE_MAX_START_TIME: Final[datetime.timedelta] = datetime.timedelta(minutes=3)
_EC2_INSTANCE_MAX_START_TIME: Final[datetime.timedelta] = datetime.timedelta(minutes=1)
_DASK_SCHEDULER_READYNESS_MAX_TIME: Final[datetime.timedelta] = datetime.timedelta(
minutes=1
)
Expand Down
Loading