Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨Autoscaling: Change max time to wait for EC2 readyness to 1 minute #5739

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 25, 2024

What do these changes do?

Tests have shown that with the newest tooling we are now down from 3 minutes to <1 minutes to start an EC2 instance.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Apr 25, 2024
@sanderegg sanderegg added this to the Enchanted Odyssey milestone Apr 25, 2024
@sanderegg sanderegg self-assigned this Apr 25, 2024
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.3%. Comparing base (cafbf96) to head (3e92c91).
Report is 151 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5739      +/-   ##
=========================================
- Coverage    84.5%   66.3%   -18.2%     
=========================================
  Files          10     607     +597     
  Lines         214   30204   +29990     
  Branches       25     204     +179     
=========================================
+ Hits          181   20052   +19871     
- Misses         23   10100   +10077     
- Partials       10      52      +42     
Flag Coverage Δ
integrationtests 63.9% <ø> (?)
unittests 97.4% <100.0%> (+12.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/src/simcore_service_autoscaling/core/settings.py 97.9% <ø> (ø)
.../simcore_service_clusters_keeper/utils/clusters.py 97.5% <100.0%> (ø)

... and 614 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!
Perhaps you can add a not in the code about this change? or simply a link to this PR?

@sanderegg
Copy link
Member Author

Amazing! Perhaps you can add a not in the code about this change? or simply a link to this PR?

@pcrespov what note? this is just an empirical value based on the usual time it takes to start an EC2 machine. I started with a conservative value, and now since the latest tooling is in place (using latest ubuntu instead of some obscure AMI-ID), the EC2 startup time was divided by 5

@sanderegg sanderegg merged commit 0582925 into ITISFoundation:master Apr 25, 2024
56 checks passed
@sanderegg sanderegg deleted the autoscaling/adapt-ec2-max-startup-time branch April 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants