-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Autoscaling: Change max time to wait for EC2 readyness to 1 minute #5739
🎨Autoscaling: Change max time to wait for EC2 readyness to 1 minute #5739
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀 🚀 🚀 🚀 🚀 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5739 +/- ##
=========================================
- Coverage 84.5% 66.3% -18.2%
=========================================
Files 10 607 +597
Lines 214 30204 +29990
Branches 25 204 +179
=========================================
+ Hits 181 20052 +19871
- Misses 23 10100 +10077
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Perhaps you can add a not in the code about this change? or simply a link to this PR?
@pcrespov what note? this is just an empirical value based on the usual time it takes to start an EC2 machine. I started with a conservative value, and now since the latest tooling is in place (using latest ubuntu instead of some obscure AMI-ID), the EC2 startup time was divided by 5 |
What do these changes do?
Tests have shown that with the newest tooling we are now down from 3 minutes to <1 minutes to start an EC2 instance.
Related issue/s
How to test
Dev-ops checklist