Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Dask backend: Enable /metrics endpoint for scraping with prometheus #5264

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 23, 2024

What do these changes do?

This PR enables the /metrics endpoint on the dask subsystem. I.e. both the dask-scheduler and the dask-sidecar(s) do provide that endpoint.

Related issue/s

How to test

make build up-prod
# go to the dask-scheduler entrypoint, i.e. http://127.0.0.1:8787/metrics
# go to the dask-sidecar entrypoint, i.e. http://127.0.0.1:8788/metrics

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Jan 23, 2024
@sanderegg sanderegg added this to the This is Sparta! milestone Jan 23, 2024
@sanderegg sanderegg self-assigned this Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f136a0) 87.3% compared to head (28ea6f3) 66.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5264      +/-   ##
=========================================
- Coverage    87.3%   66.1%   -21.2%     
=========================================
  Files        1302     990     -312     
  Lines       53251   41597   -11654     
  Branches     1167     629     -538     
=========================================
- Hits        46495   27521   -18974     
- Misses       6507   13952    +7445     
+ Partials      249     124     -125     
Flag Coverage Δ
integrationtests 51.9% <ø> (-13.2%) ⬇️
unittests 82.5% <ø> (-2.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 634 files with indirect coverage changes

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sanderegg sanderegg merged commit eaff29d into ITISFoundation:master Jan 23, 2024
54 checks passed
@sanderegg sanderegg deleted the comp-backend/enable-metrics-endpoint branch January 23, 2024 10:13
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants