🐛Clusters-keeper: calling >100 times for the same new cluster now returns cached information #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:director-v2
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5201 +/- ##
========================================
- Coverage 89.4% 86.9% -2.5%
========================================
Files 1121 1031 -90
Lines 45899 44422 -1477
Branches 1057 603 -454
========================================
- Hits 41049 38631 -2418
- Misses 4619 5650 +1031
+ Partials 231 141 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bisgaard-itis
approved these changes
Dec 21, 2023
sanderegg
force-pushed
the
comp-backend/allow-to-start-many-pipelines
branch
from
52048d6
to
0495f0d
Compare
sanderegg
force-pushed
the
comp-backend/allow-to-start-many-pipelines
branch
from
5cd3b46
to
c1f8620
Compare
|
matusdrobuliak66
approved these changes
Dec 22, 2023
sanderegg
changed the title
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
when running many jobs through the public API, we actually create as many projects as jobs for 1 same user.
When starting them all at the same time, we actually need to get_or_create the very same cluster at the same time which means there are as many very same call to the clusters-keeper via RPC, then locking a distributed lock, then calling into AWS.
This PR ensures that:
In effect, this prevents calls from going more often than once every 5 seconds for the same user_id/wallet_id combination
Related issue/s
How to test
Dev Checklist
DevOps Checklist