-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛e2e testing: replacement of sleepers using Playwright (preparation for upscaling of ext clusters) #5167
🐛e2e testing: replacement of sleepers using Playwright (preparation for upscaling of ext clusters) #5167
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5167 +/- ##
========================================
+ Coverage 87.2% 87.4% +0.1%
========================================
Files 1282 1282
Lines 52651 52651
Branches 1141 1141
========================================
+ Hits 45946 46022 +76
+ Misses 6460 6384 -76
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. |
84e5516
to
b8ef9da
Compare
b8ef9da
to
b0ad84c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super cool!
Looks good to me. I added a few suggestions and questions for my own understanding.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nice. Thanks for the effort!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanderegg An additional question
I see in the above video that not all the sleepers show any outputs. Is that intended?
e41ab65
to
f1e5fcc
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
…or upscaling of ext clusters) (ITISFoundation#5167)
What do these changes do?
This PR leverages Playwright and replaces the puppeteer-based sleepers e2e test by:
Bonuses:
NOTE: The video was generated using Playwright --video=on flag!
8e7e530c20a3bf0e8bc7d91e73f4a0a6.webm
Related issue/s
How to test
against any deployment
against local deployment only
Dev Checklist
DevOps Checklist