🐛 Less stringent regex for AWS tag value #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:autoscaling
sanderegg
force-pushed
the
comp-backend/regex-too-hard
branch
from
1bf2c63
to
aa19565
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit aa19565 and detected 0 issues on this pull request. View more on Code Climate. |
pcrespov
approved these changes
Dec 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5155 +/- ##
=========================================
- Coverage 85.2% 80.3% -4.9%
=========================================
Files 1277 383 -894
Lines 52421 13484 -38937
Branches 1133 221 -912
=========================================
- Hits 44674 10841 -33833
+ Misses 7514 2601 -4913
+ Partials 233 42 -191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
approved these changes
Dec 11, 2023
bisgaard-itis
approved these changes
Dec 11, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
this PR let the regex be more flexible (even though it is not strictly speaking compatible with AWS tag values)
Related issue/s
How to test
Dev Checklist
DevOps Checklist