Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️Maintenance/remove minio-sdk #5120

Merged
merged 34 commits into from
Dec 5, 2023
Merged

♻️Maintenance/remove minio-sdk #5120

merged 34 commits into from
Dec 5, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 1, 2023 •
edited
Loading

What do these changes do?

  • totally removes the use of python minio library
  • removes filestash/onlyoffice from the docker-compose-ops stack as they are useless (minio has its own UI)

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added this to the Kobayashi Maru milestone Dec 1, 2023
@sanderegg sanderegg self-assigned this Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Merging #5120 (621ee33) into master (79785ba) will decrease coverage by 0.9%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5120     +/-   ##
========================================
- Coverage    86.0%   85.2%   -0.9%     
========================================
  Files        1265    1272      +7     
  Lines       52049   52226    +177     
  Branches     1120    1129      +9     
========================================
- Hits        44803   44508    -295     
- Misses       7013    7485    +472     
  Partials      233     233
Flag Coverage Δ
integrationtests ?
unittests 85.2% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/service-library/src/servicelib/minio_utils.py 0.0% <0.0%> (ø)

... and 43 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/remove-minio branch 6 times, most recently from b2a374d to 1c92cb6 Compare December 4, 2023 13:40
@sanderegg sanderegg marked this pull request as ready for review December 4, 2023 13:40
GitHK
GitHK reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I did not see if you removed onlyoffice and fileshtash in yaml files. Did I miss it?

bisgaard-itis
bisgaard-itis approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot for cleaning up. I have a few comments/questions about cosmetics.

packages/pytest-simcore/src/pytest_simcore/aws_server.py Show resolved Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/utils_envs.py Outdated Show resolved Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/utils_envs.py Outdated Show resolved Hide resolved
@sanderegg
Copy link
Member Author

Cool. I did not see if you removed onlyoffice and fileshtash in yaml files. Did I miss it?

yep good catch. commit missing. now done

@sanderegg sanderegg requested a review from GitHK December 4, 2023 21:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 621ee33 and detected 0 issues on this pull request.

View more on Code Climate.

pcrespov
pcrespov approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh boy! 🎉 thx a lot!

@sanderegg sanderegg merged commit 691eeba into ITISFoundation:master Dec 5, 2023
56 checks passed
@sanderegg sanderegg deleted the maintenance/remove-minio branch December 5, 2023 07:35
GitHK
GitHK reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good 👍

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 5, 2023
Closed
15 tasks
@sanderegg sanderegg mentioned this pull request Dec 6, 2023
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 8, 2024
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitHK GitHK GitHK left review comments

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Kobayashi Maru
Development

Successfully merging this pull request may close these issues.
5 participants
@sanderegg @GitHK @pcrespov @matusdrobuliak66 @bisgaard-itis