-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Correctly handle file type of on-demand clusters #5101
🐛Correctly handle file type of on-demand clusters #5101
Conversation
services/director-v2/src/simcore_service_director_v2/modules/dask_clients_pool.py
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5101 +/- ##
========================================
- Coverage 70.6% 70.0% -0.6%
========================================
Files 559 563 +4
Lines 27394 28596 +1202
Branches 207 198 -9
========================================
+ Hits 19344 20029 +685
- Misses 8000 8517 +517
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/director-v2/src/simcore_service_director_v2/modules/dask_clients_pool.py
Show resolved
Hide resolved
Should this one be referenced here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
22465c1
to
62e9875
Compare
62e9875
to
a6a9511
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit a6a9511 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
This PR fixes the issue where using on-demand clusters would not properly use S3 file types but instead were locked on presigned links.
This had the consequence of limiting uploads to max 5Gib, but is also the sad fact that we still do not properly fixed it by using the public API from the dask-sidecars.
Related issue/s
How to test
Use a python runner and run the following script:
Dev Checklist
DevOps Checklist