-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Dask sidecar: pass job origin and show child computational service logs in workbench #5054
✨Dask sidecar: pass job origin and show child computational service logs in workbench #5054
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5054 +/- ##
=========================================
+ Coverage 85.1% 87.3% +2.2%
=========================================
Files 1263 924 -339
Lines 51910 40711 -11199
Branches 1114 207 -907
=========================================
- Hits 44188 35559 -8629
+ Misses 7489 5103 -2386
+ Partials 233 49 -184
Flags with carried forward coverage won't be shown. Click here to find out more.
|
18a09c9
to
f4a599c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a few comments
packages/dask-task-models-library/src/dask_task_models_library/container_tasks/events.py
Show resolved
Hide resolved
packages/dask-task-models-library/src/dask_task_models_library/container_tasks/protocol.py
Show resolved
Hide resolved
f4a599c
to
faadab7
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit faadab7 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice cleanup!
What do these changes do?
This PR brings:
Related issue/s
How to test
Dev Checklist
DevOps Checklist