Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Clusters-keeper: renamed ENV variables #5032

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 14, 2023

What do these changes do?

changes in ENVs that went under the radar.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit add522b and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #5032 (add522b) into master (125ae0b) will decrease coverage by 5.9%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5032      +/-   ##
=========================================
- Coverage    88.1%   82.3%    -5.9%     
=========================================
  Files         750    1250     +500     
  Lines       34023   51237   +17214     
  Branches      689    1107     +418     
=========================================
+ Hits        30003   42199   +12196     
- Misses       3863    8806    +4943     
- Partials      157     232      +75     
Flag Coverage Δ
integrationtests 57.6% <ø> (-7.4%) ⬇️
unittests 81.3% <ø> (-5.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_clusters_keeper/utils/clusters.py 71.7% <ø> (ø)

... and 647 files with indirect coverage changes

@sanderegg sanderegg merged commit a4d9fec into ITISFoundation:master Nov 14, 2023
56 checks passed
@sanderegg sanderegg deleted the clusters-keeper/fix-env-variables branch November 14, 2023 16:05
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants