Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Re-introduce aws-library #5031

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 14, 2023

What do these changes do?

  • re-introduce AWS-library without leaking secrets.

aws-library is a package wrapping the access to EC2 into one python package.
used by clusters-keeper and autoscaling services.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added a:autoscaling autoscaling service in simcore's stack a:clusters-keeper a:aws-library labels Nov 14, 2023
@sanderegg sanderegg added this to the 7peaks milestone Nov 14, 2023
@sanderegg sanderegg self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #5031 (89e5ba5) into master (4d75a0c) will decrease coverage by 2.3%.
The diff coverage is 98.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5031     +/-   ##
========================================
- Coverage    87.2%   85.0%   -2.3%     
========================================
  Files        1245    1250      +5     
  Lines       51257   51230     -27     
  Branches     1085    1107     +22     
========================================
- Hits        44717   43550   -1167     
- Misses       6301    7448   +1147     
+ Partials      239     232      -7     
Flag Coverage Δ
integrationtests ?
unittests 85.0% <98.3%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/aws-library/src/aws_library/__init__.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/client.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/errors.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/models.py 100.0% <100.0%> (ø)
packages/aws-library/src/aws_library/ec2/utils.py 100.0% <100.0%> (ø)
...brary/api_schemas_clusters_keeper/ec2_instances.py 100.0% <100.0%> (ø)
...kages/settings-library/src/settings_library/ec2.py 100.0% <100.0%> (ø)
...g/src/simcore_service_autoscaling/core/settings.py 100.0% <100.0%> (ø)
...oscaling/src/simcore_service_autoscaling/models.py 100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py 95.8% <100.0%> (+<0.1%) ⬆️
... and 22 more

... and 70 files with indirect coverage changes

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit 89e5ba5 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@sanderegg sanderegg merged commit 992d8be into ITISFoundation:master Nov 14, 2023
43 of 53 checks passed
@sanderegg sanderegg deleted the maintenance/aws-base-package branch November 14, 2023 13:33
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 23, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack a:aws-library a:clusters-keeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants