🐛Dynamic autoscaling: not scaling beside 1 machine

[sanderegg]

What do these changes do?

This PR fixes the following issue:

• dynamic autoscaling service setup
• creating dynamic services does create a new machine and goes there
• creating another service does not create a new machine and the service stays forever

root cause:

• autoscaling analyzes the current cluster and divides it in active, pending, drained and missing nodes respectively,
• it then tries to assign the "unrunnable" tasks to these 4 types of nodes in this order,
• it was not subtracting the current usage of the active node, therefore always thinking there were enough machines around.

Testing can only be made directly on AWS machines, which makes testing a bit annoying.

to @pcrespov : I will not refactor yet the filter function as I do not want to break this now again. especially since testing is tedious.

Related issue/s

How to test

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

Merging #5026 (9f1e5c8) into master (992d8be) will decrease coverage by 13.9%.
The diff coverage is 100.0%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5026      +/-   ##
=========================================
- Coverage    80.3%   66.5%   -13.9%     
=========================================
  Files        1250     547     -703     
  Lines       51230   27727   -23503     
  Branches     1107     198     -909     
=========================================
- Hits        41168   18447   -22721     
+ Misses       9830    9230     -600     
+ Partials      232      50     -182     

Flag	Coverage Δ
integrationtests	64.9% <ø> (+13.2%)	⬆️
unittests	98.5% <100.0%> (+19.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...oscaling/src/simcore_service_autoscaling/models.py	100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py	95.0% <100.0%> (-0.9%)	⬇️
...vice_autoscaling/modules/auto_scaling_mode_base.py	100.0% <100.0%> (ø)
...scaling/modules/auto_scaling_mode_computational.py	100.0% <100.0%> (ø)
...e_autoscaling/modules/auto_scaling_mode_dynamic.py	100.0% <100.0%> (ø)
...ore_service_autoscaling/utils/auto_scaling_core.py	94.2% <100.0%> (-0.2%)	⬇️
...service_autoscaling/utils/computational_scaling.py	100.0% <100.0%> (ø)
...mcore_service_autoscaling/utils/dynamic_scaling.py	100.0% <100.0%> (ø)

... and 948 files with indirect coverage changes

[codeclimate]

The PR diff size of 5129 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5129 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5136 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5245 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5249 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5249 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5307 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5308 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5309 lines exceeds the maximum allowed for the inline comments feature.

[codeclimate]

The PR diff size of 5309 lines exceeds the maximum allowed for the inline comments feature.

[matusdrobuliak66]

thanks 👍

[codeclimate]

The PR diff size of 5300 lines exceeds the maximum allowed for the inline comments feature.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.6% Duplication

[codeclimate]

Code Climate has analyzed commit 9f1e5c8 and detected 0 issues on this pull request.

View more on Code Climate.

[GitHK]

👍