-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Comp-backend override resources with selected hardware #4954
✨Comp-backend override resources with selected hardware #4954
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4954 +/- ##
========================================
Coverage 86.8% 86.8%
========================================
Files 1210 1056 -154
Lines 50256 47076 -3180
Branches 1076 891 -185
========================================
- Hits 43629 40903 -2726
+ Misses 6390 5975 -415
+ Partials 237 198 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
63b5a9e
to
80fe67f
Compare
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/clusters_keeper/clusters.py
Outdated
Show resolved
Hide resolved
...ages/service-library/src/servicelib/rabbitmq/rpc_interfaces/clusters_keeper/ec2_instances.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/clusters_keeper/clusters.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/dask_scheduler.py
Outdated
Show resolved
Hide resolved
...ces/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_utils.py
Outdated
Show resolved
Hide resolved
cdb9e5d
to
80ce87e
Compare
...ces/director-v2/src/simcore_service_director_v2/modules/db/repositories/comp_tasks/_utils.py
Outdated
Show resolved
Hide resolved
This reverts commit 9c7e7273e073082671bde23b6f1d75af12fee187.
commit 48e17132fff9559dcd8ca14fc1cd78788d0c1482 Author: sanderegg <[email protected]> Date: Tue Oct 31 09:25:48 2023 +0100 refactor, re-use models commit f2fd29973be314417cacaa81d65bf3a66ac94377 Author: sanderegg <[email protected]> Date: Tue Oct 31 09:22:01 2023 +0100 moved service resources
68979ff
to
5438213
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit f3beec4 and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
In billable products, this PR ensures the service resources are set according to the selected EC2 instance type with a safety margin of 1GiB for now as it seems that the dask-sidecar sees a bit less than what is expected.
details
bonus
Related issue/s
How to test
DevOps Checklist