Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Dask-sidecar shall use all available resources for selected instance types #4927

Conversation

sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg self-assigned this Oct 26, 2023
@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Oct 26, 2023
@sanderegg sanderegg added this to the Microhistory milestone Oct 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 26, 2023

Code Climate has analyzed commit 31b76c1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4927 (31b76c1) into master (9538a3a) will decrease coverage by 21.0%.
Report is 1 commits behind head on master.
The diff coverage is 92.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4927      +/-   ##
=========================================
- Coverage    86.8%   65.8%   -21.0%     
=========================================
  Files        1155     523     -632     
  Lines       49036   26767   -22269     
  Branches     1066     195     -871     
=========================================
- Hits        42567   17635   -24932     
- Misses       6234    9083    +2849     
+ Partials      235      49     -186     
Flag Coverage Δ
integrationtests 65.1% <ø> (+<0.1%) ⬆️
unittests 91.3% <92.8%> (+6.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ce_dask_sidecar/computational_sidecar/constants.py 100.0% <ø> (ø)
...dask_sidecar/computational_sidecar/docker_utils.py 91.4% <100.0%> (+<0.1%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 97.5% <100.0%> (+<0.1%) ⬆️
...decar/src/simcore_service_dask_sidecar/settings.py 100.0% <100.0%> (ø)
...service_dask_sidecar/computational_sidecar/core.py 99.1% <83.3%> (-0.9%) ⬇️

... and 941 files with indirect coverage changes

@sanderegg
Copy link
Member Author

replaced by #4954

@sanderegg sanderegg closed this Oct 30, 2023
@sanderegg sanderegg deleted the comp-backend/dask-sidecar-use-all-resources-mode branch October 30, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant