-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨🐛Webserver: enable socketio horizontal scaling + ensure only 1 update goes through (⚠️ devops) #4286
✨🐛Webserver: enable socketio horizontal scaling + ensure only 1 update goes through (⚠️ devops) #4286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4286 +/- ##
=========================================
+ Coverage 72.6% 83.7% +11.0%
=========================================
Files 781 468 -313
Lines 33173 24364 -8809
Branches 600 173 -427
=========================================
- Hits 24087 20393 -3694
+ Misses 8948 3922 -5026
+ Partials 138 49 -89
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/web/server/src/simcore_service_webserver/socketio/server.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice to see this one
services/web/server/src/simcore_service_webserver/socketio/server.py
Outdated
Show resolved
Hide resolved
8cff96e
to
e4ef880
Compare
da5dbf7
to
70d4c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!! Some minor comments
Thanks for catching up on this topic since so far I was not able to tackle it!
services/web/server/src/simcore_service_webserver/application_settings_utils.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/socketio/server.py
Outdated
Show resolved
Hide resolved
70d4c06
to
2aad3ba
Compare
dfba6b2
to
8b9d24d
Compare
8b9d24d
to
8f3ea94
Compare
Code Climate has analyzed commit 8f3ea94 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
LISTEN
vs the comp_tasks table in the dB, when a comp_tasks outputs/run_hash or state changes it triggers, update the projects table in the dB and notify the connected userswb-db-event-listener
Bonuses
Related issue/s
How to test
DevOps Checklist