Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨RabbitMQ: add persistency on rabbitmq service #4280

Merged
merged 1 commit into from
May 30, 2023
Merged

✨RabbitMQ: add persistency on rabbitmq service #4280

merged 1 commit into from
May 30, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 30, 2023 •
edited
Loading

What do these changes do?

  • adds a named volume to keep rabbitmq data between rabbitmq restarts

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added this to the Pastel de Nata milestone May 30, 2023
@sanderegg sanderegg self-assigned this May 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codeclimate
Copy link

codeclimate bot commented May 30, 2023

Code Climate has analyzed commit ebf3798 and detected 0 issues on this pull request.

View more on Code Climate.

mguidon
mguidon approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mrnicegyu11
mrnicegyu11 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

GitHK
GitHK approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for this one!

matusdrobuliak66
matusdrobuliak66 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #4280 (ebf3798) into master (424c6e4) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4280   +/-   ##
======================================
  Coverage    85.7%   85.7%           
======================================
  Files         971     974    +3     
  Lines       41853   41921   +68     
  Branches      964     964           
======================================
+ Hits        35906   35966   +60     
- Misses       5725    5734    +9     
+ Partials      222     221    -1
Flag Coverage Δ
integrationtests 68.9% <ø> (-0.1%) ⬇️
unittests 82.6% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes

@sanderegg sanderegg force-pushed the enhancement/add-rabbitmq-data-volume branch from ebf3798 to b66c85c Compare May 30, 2023 08:26
@sanderegg sanderegg merged commit b004ab1 into ITISFoundation:master May 30, 2023
@sanderegg sanderegg deleted the enhancement/add-rabbitmq-data-volume branch May 30, 2023 08:26
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
Closed
5 tasks
@GitHK GitHK mentioned this pull request May 31, 2023
Closed
@sanderegg sanderegg mentioned this pull request May 31, 2023
Open
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2023
Closed
17 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mguidon mguidon mguidon approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@GitHK GitHK GitHK approved these changes

@Surfict Surfict Awaiting requested review from Surfict

Assignees

@sanderegg sanderegg

Labels
None yet
Projects
None yet
Milestone
Pastel de Nata
Development

Successfully merging this pull request may close these issues.

Missing docker volume for RabbitMQ: Connection to RabbitMQ
5 participants
@sanderegg @GitHK @mrnicegyu11 @mguidon @matusdrobuliak66