Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 passing data from a service to another fails #4257

Merged
merged 3 commits into from
May 22, 2023
Merged

🐛 passing data from a service to another fails #4257

merged 3 commits into from
May 22, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 22, 2023 •
edited
Loading

What do these changes do?

  • @elisabettai found out that it was not possible to connect 2 services together anymore. the /inputs:match endpoint of the webserver returns 422 (e.g. 2 sleepers could not be connected anymore)

This PR fixes this problem

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label May 22, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 22, 2023
@sanderegg sanderegg self-assigned this May 22, 2023
@sanderegg sanderegg changed the title 🐛 passing data from a service to another failed 🐛 passing data from a service to another fails May 22, 2023
elisabettai
elisabettai approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the quick fix!

@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #4257 (c5c135b) into master (3ff6e30) will decrease coverage by 14.5%.
The diff coverage is 70.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4257      +/-   ##
=========================================
- Coverage    83.3%   68.8%   -14.5%     
=========================================
  Files         921     399     -522     
  Lines       39784   20661   -19123     
  Branches      963     173     -790     
=========================================
- Hits        33166   14232   -18934     
+ Misses       6397    6380      -17     
+ Partials      221      49     -172
Flag Coverage Δ
integrationtests 68.8% <70.0%> (+<0.1%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_service_webserver/catalog/_handlers.py 49.5% <70.0%> (-3.3%) ⬇️

... and 685 files with indirect coverage changes

@sanderegg sanderegg requested a review from pcrespov May 22, 2023 13:08
pcrespov
pcrespov approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx so much!

services/web/server/src/simcore_service_webserver/catalog/_handlers.py Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit c5c135b and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg enabled auto-merge (squash) May 22, 2023 13:41
@sanderegg sanderegg merged commit f95c13f into ITISFoundation:master May 22, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 23, 2023
Closed
15 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
Closed
24 tasks
@sanderegg sanderegg mentioned this pull request May 31, 2023
Open
@sanderegg sanderegg deleted the bugfix/catalog_not_working branch June 8, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK GitHK approved these changes

Assignees

@sanderegg sanderegg

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Pastel de Nata
Development

Successfully merging this pull request may close these issues.
5 participants
@sanderegg @GitHK @elisabettai @pcrespov @matusdrobuliak66