-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Api-server wrong start/stop/submit timestamps #4254
🐛Api-server wrong start/stop/submit timestamps #4254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4254 +/- ##
========================================
- Coverage 82.6% 82.5% -0.2%
========================================
Files 957 957
Lines 41505 41542 +37
Branches 963 963
========================================
- Hits 34300 34275 -25
- Misses 6984 7059 +75
+ Partials 221 208 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thx for the addition!
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/utils/solver_job_models_converters.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/projects_db.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
also pass error in errors
3ea46f8
to
216887a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 216887a and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
fixes #4231
Bonuses:
Related issue/s
How to test
DevOps Checklist