Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 No longer upload output ports when study is in read only mode #4207

Merged
merged 5 commits into from
May 10, 2023
Merged

🐛 No longer upload output ports when study is in read only mode #4207

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30c297b
read only mode does not upload outputs
May 9, 2023
d73215e
Merge branch 'master' into pr-osparc-read-only-no-watcher
GitHK May 9, 2023
dbf7135
Merge branch 'master' into pr-osparc-read-only-no-watcher
GitHK May 9, 2023
bf29be6
Merge branch 'master' into pr-osparc-read-only-no-watcher
GitHK May 9, 2023
76b118e
disable output watcher in READ ONLY mode
May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,15 @@ async def progress_create_containers(
dynamic_sidecar_endpoint, compose_spec, progress_create_containers
)

await dynamic_sidecar_client.enable_service_outputs_watcher(
dynamic_sidecar_endpoint
)
# NOTE: when in READ ONLY mode disable the outputs watcher
if scheduler_data.dynamic_sidecar.service_removal_state.can_save:
await dynamic_sidecar_client.enable_service_outputs_watcher(
dynamic_sidecar_endpoint
)
else:
await dynamic_sidecar_client.disable_service_outputs_watcher(
dynamic_sidecar_endpoint
)

# Starts PROXY -----------------------------------------------
# The entrypoint container name was now computed
Expand Down