🐛 No longer upload output ports when study is in read only mode

[GitHK]

What do these changes do?

Currently, due to a side effect outputs are not uploaded by the sidecar. Storage raises an error due to missing permissions to upload files when sidecar is running in read only mode.

This properly addresses the issue.

NOTE with @elisabettai we discussed about this. When opened in read only you cannot push outputs to downstream services. I'm not sure how this works for legacy services.

Related issue/s

• requires ♻️ Propagate can_save when starting service 🚨 #4202
• fixes Read only study uploads outputs for dynamic services #4044
• improving dynamic-sidecar design osparc-issues#638

How to test

DevOps Checklist

[GitHK]

FYI: Just something to keep in mid, read my notes above. Thanks!
@mguidon @mrnicegyu11 @odeimaiz @elisabettai @colinRawlings

[mrnicegyu11]

Could I bother you to in fact check and write down here how it works for legacy services' outputs if they are in read only mode?

[mrnicegyu11]

thanks a lot for this! small and clean

[codecov]

Codecov Report

Merging #4207 (76b118e) into master (a7ab0fb) will decrease coverage by 11.4%.
The diff coverage is 66.6%.

@@            Coverage Diff            @@
##           master   #4207      +/-   ##
=========================================
- Coverage    84.3%   72.9%   -11.4%     
=========================================
  Files         964     406     -558     
  Lines       41703   20870   -20833     
  Branches      953     173     -780     
=========================================
- Hits        35169   15228   -19941     
+ Misses       6317    5593     -724     
+ Partials      217      49     -168     

Flag	Coverage Δ
integrationtests	67.3% <66.6%> (+1.4%)	⬆️
unittests	86.3% <0.0%> (+4.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...modules/dynamic_sidecar/scheduler/_core/_events.py	96.7% <66.6%> (-0.6%)	⬇️

... and 715 files with indirect coverage changes

[GitHK]

Could I bother you to in fact check and write down here how it works for legacy services' outputs if they are in read only mode?

@mrnicegyu11 so in case of comp and legacy services outputs will not be updated. Especially for computational, since the run button is disabled.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication

[codeclimate]

Code Climate has analyzed commit 76b118e and detected 0 issues on this pull request.

View more on Code Climate.