Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Minor fix: adding log_format_local_dev_enabled env-var to the dynamic sidecar #4173

Merged
merged 11 commits into from
May 4, 2023
+4 −0
Merged

🐛 Minor fix: adding log_format_local_dev_enabled env-var to the dynamic sidecar #4173

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
161f469
adding log_format_local_dev_enebaled ENV var to the dynamic sidecar
matusdrobuliak66 Apr 27, 2023
3f5024c
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 3, 2023
64b1227
correction of failing test
matusdrobuliak66 May 3, 2023
f402737
correction
matusdrobuliak66 May 3, 2023
591f4f2
correction
matusdrobuliak66 May 3, 2023
8a28249
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 4, 2023
b39e1bc
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 4, 2023
e1044ec
fixing test
matusdrobuliak66 May 4, 2023
d38ad34
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 4, 2023
dac3528
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 4, 2023
4237d4f
Merge branch 'master' into maintenance/passing-env-variable-to-dynami…
matusdrobuliak66 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def _get_environment_variables(
"DY_SIDECAR_USER_ID": f"{scheduler_data.user_id}",
"DYNAMIC_SIDECAR_COMPOSE_NAMESPACE": compose_namespace,
"DYNAMIC_SIDECAR_LOG_LEVEL": app_settings.DYNAMIC_SERVICES.DYNAMIC_SIDECAR.DYNAMIC_SIDECAR_LOG_LEVEL,
"DIRECTOR_V2_LOG_FORMAT_LOCAL_DEV_ENABLED": f"{app_settings.DIRECTOR_V2_LOG_FORMAT_LOCAL_DEV_ENABLED}",
"POSTGRES_DB": f"{app_settings.POSTGRES.POSTGRES_DB}",
"POSTGRES_ENDPOINT": f"{app_settings.POSTGRES.POSTGRES_HOST}:{app_settings.POSTGRES.POSTGRES_PORT}",
"POSTGRES_HOST": f"{app_settings.POSTGRES.POSTGRES_HOST}",
Expand Down
1 change: 1 addition & 0 deletions services/director-v2/tests/unit/test_modules_dynamic_sidecar_docker_service_specs_sidecar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"DY_SIDECAR_USER_SERVICES_HAVE_INTERNET_ACCESS",
"DYNAMIC_SIDECAR_COMPOSE_NAMESPACE",
"DYNAMIC_SIDECAR_LOG_LEVEL",
"DIRECTOR_V2_LOG_FORMAT_LOCAL_DEV_ENABLED",
"POSTGRES_DB",
"POSTGRES_ENDPOINT",
"POSTGRES_HOST",
Expand Down