🐛 Minor fix: adding log_format_local_dev_enabled env-var to the dynamic sidecar
#4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4173 +/- ##
=========================================
- Coverage 84.7% 68.9% -15.9%
=========================================
Files 958 369 -589
Lines 41558 19115 -22443
Branches 955 0 -955
=========================================
- Hits 35236 13185 -22051
+ Misses 6105 5930 -175
+ Partials 217 0 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matusdrobuliak66
requested review from
sanderegg,
pcrespov and
GitHK
as code owners
GitHK
reviewed
May 3, 2023
services/director-v2/tests/unit/test_modules_dynamic_sidecar_docker_service_specs_sidecar.py
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
May 3, 2023
pcrespov
approved these changes
May 3, 2023
pcrespov
changed the title
log_format_local_dev_enabled env-var to the dynamic sidecar
sanderegg
approved these changes
May 4, 2023
|
Code Climate has analyzed commit 4237d4f and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
DevOps Checklist